Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/338 limit allowed chars in username or do not use username in code #343

Conversation

FranSlot
Copy link
Contributor

Fixes #338.

Copy link

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
1 0 0 1 100

Passed Tests

Name ⏱️ Duration Suite
Should be able to access the Home page 3.577 s RAPLive

Copy link
Contributor

@KlaasDijkstraOrdina KlaasDijkstraOrdina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De regex is goed (verified met https://www.phpliveregex.com/#tab-preg-replace).
$studentName wordt nu veranderd. Naast hostname, wordt deze ook in de manifest, tlsSecret en manifest filename verwerkt. Was dit de bedoeling? Ik kan gevolgen hiervan nl. niet overzien.

@FranSlot
Copy link
Contributor Author

Dit zijn allemaal namen voor verschillende resources, welke de student naam als onderdeel hebben van die naam. Dat deze ook opgeschoond worden is goed en gewild. Zo voorkomen we weer andere bugs met de namen van de resources.

Copy link
Contributor

@KlaasDijkstraOrdina KlaasDijkstraOrdina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, dan is het goed.

@FranSlot FranSlot merged commit 4d7657a into main Dec 21, 2023
3 checks passed
@FranSlot FranSlot deleted the feature/338-limit-allowed-chars-in-username-or-do-not-use-username-in-code branch December 21, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Limit allowed chars in username or do not use username in code
2 participants